Add try with resources to Challenge redislabs-training#3 solution

alex-d-bondarev · Oct 9, 2024 · effc875 · effc875
1 parent aff471a
commit effc875
Showing 1 changed file with 10 additions and 10 deletions.
diff --git a/src/main/java/com/redislabs/university/RU102J/dao/SiteStatsDaoRedisImpl.java b/src/main/java/com/redislabs/university/RU102J/dao/SiteStatsDaoRedisImpl.java
@@ -80,20 +80,20 @@ private void updateBasic(Jedis jedis, String key, MeterReading reading) {
 
     // Challenge #3
     private void updateOptimized(Jedis jedis, String key, MeterReading reading) {
-        CompareAndUpdateScript compareScript = new CompareAndUpdateScript(jedisPool);
+        String reportingTime = ZonedDateTime.now(ZoneOffset.UTC).toString();
 
-        Transaction jedisT = jedis.multi();
+        try (Transaction jedisT = jedis.multi()) {
 
-        String reportingTime = ZonedDateTime.now(ZoneOffset.UTC).toString();
-        jedisT.hset(key, SiteStats.reportingTimeField, reportingTime);
-        jedisT.hincrBy(key, SiteStats.countField, 1);
-        jedisT.expire(key, WEEK_SECONDS);
+            jedisT.hset(key, SiteStats.reportingTimeField, reportingTime);
+            jedisT.hincrBy(key, SiteStats.countField, 1);
+            jedisT.expire(key, WEEK_SECONDS);
 
-        compareScript.updateIfGreater(jedisT, key, SiteStats.maxWhField, reading.getWhGenerated());
-        compareScript.updateIfLess(jedisT, key, SiteStats.minWhField, reading.getWhGenerated());
-        compareScript.updateIfGreater(jedisT, key, SiteStats.maxCapacityField, getCurrentCapacity(reading));
+            compareAndUpdateScript.updateIfGreater(jedisT, key, SiteStats.maxWhField, reading.getWhGenerated());
+            compareAndUpdateScript.updateIfLess(jedisT, key, SiteStats.minWhField, reading.getWhGenerated());
+            compareAndUpdateScript.updateIfGreater(jedisT, key, SiteStats.maxCapacityField, getCurrentCapacity(reading));
 
-        jedisT.exec();
+            jedisT.exec();
+        }
     }
 
     private Double getCurrentCapacity(MeterReading reading) {