Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix return type of intent request util functions #702

Open
wants to merge 1 commit into
base: 2.0.x
Choose a base branch
from

Conversation

arnaudcourtecuisse
Copy link

@arnaudcourtecuisse arnaudcourtecuisse commented Jan 25, 2022

Description

These function can return nullish values but are declared to return a non-nullish type (either Slot or SlotValue or string)
I fixed the return type declaration to match the implementation.

Motivation and Context

It fixes issue #701

Testing

I used npm link so that my skill uses my local version of ask-sdk-core. Then, with ngrok, I exposed my local skill endpoint and tested it with my Alexa device.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs(Add new document content)
  • Translate Docs(Translate document content)

Breaks TS builds that handled the nullish value at runtime with a try/catch.

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • My commit message follows Conventional Commit Guideline

License

  • By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants