-
-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated upstream repo & app style for jenkins, minio and grafana #280
Conversation
df1b428
to
6d45266
Compare
a4d8b8e
to
1fb142e
Compare
@alexellis @Waterdrips Can you please review it? |
cmd/apps/grafana_app.go
Outdated
@@ -36,13 +37,28 @@ func MakeInstallGrafana() *cobra.Command { | |||
const chartVersion = "5.0.4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add the --set flag to this app, then merge the set values with overrides just before calling the install?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Waterdrips Since we are using helm version v3.1.2
in arkade. Grafana helm charts above 6.0.0 recommend helm version >= 3.4.0
. I think which is why the grafana version was hardcoded earlier itself.
Possibly @aidun can put some more lights on it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some charts that won't install with a newer helm version. The Grafana chart may recommend 3.4.0, but is it a hard requirement?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried it and nothing broke in installation. Not sure, why the recommendation from grafana team. helm 3.4.0 is recommended for chart from 6.0.0
db529e9
to
d7e46d6
Compare
cmd/apps/grafana_app.go
Outdated
|
||
grafana.RunE = func(command *cobra.Command, args []string) error { | ||
|
||
const chartVersion = "5.0.4" | ||
|
||
// Get all flags | ||
kubeConfigPath, _ := command.Flags().GetString("kubeconfig") | ||
kubeConfigPath, err := command.Flags().GetString("kubeconfig") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you move the error handling into PreRunE
- there are some examples you can follow in the code elsewhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Signed-off-by: Nitishkumar Singh <[email protected]> updated grafana, minio and jenkins to new style Signed-off-by: Nitishkumar Singh <[email protected]> removed additional commented code Signed-off-by: Nitishkumar Singh <[email protected]> included set options Signed-off-by: Nitishkumar Singh <[email protected]> moved flag error handling to prerun Signed-off-by: Nitishkumar Singh <[email protected]>
d7e46d6
to
f7d12ba
Compare
@Waterdrips please can you give this a final pass? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Nitishkumar Singh [email protected]
New Upstream repo urls has been updated for jenkins, minio and grafana
Description
Motivation and Context
relates Notice: the stable Helm charts have been deprecated, new alternatives are required #274
How Has This Been Tested?
Jenkins
Install Jenkins
arkade install jenkins
Get Credentials
Port-forward the Jenkins service
kubectl port-forward svc/jenkins 8080:8080 &
Open the Jenkins UI at:
echo http://127.0.0.1:8080
Use Credentials obtained in step 2 for login
minio
Install minio
arkade install minio
Forward the minio port to your machine
kubectl port-forward -n default svc/minio 9000:9000 &
Get the access and secret key to gain access to minio
mc config host add minio http://127.0.0.1:9000 $ACCESSKEY $SECRETKEY
mc ls minio
Grafana
Install grafana
arkade install grafana
Get the admin password:
kubectl get secret --namespace grafana grafana -o jsonpath="{.data.admin-password}" | base64 --decode ; echo
Expose the service via port-forward:
kubectl --namespace grafana port-forward service/grafana 3000:80
Use credential obtained in step2 with username admin to login on grafana
Types of changes
Checklist:
git commit -s