Add "config" package #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- adds a config package and unit tests to allow Derek to be configured by a struct. The new struct reads data from env-vars and from disk including throwing errors when data is missing. - application renamed application_id (env-var) - access_token renamed personal_access_token (env-var) and documented in GET.md - godoc added to packages / functions - unit tests added for hmacValidation() method - minor version of Golang SDK bumped in Dockerfile Tested through unit tests and go build with Go 1.10.4 Signed-off-by: Alex Ellis <[email protected]>
- fixes broken unit tests from Docker build Signed-off-by: Alex Ellis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alex Ellis [email protected]
Description
Add "config" package
Motivation and Context
Part of the work for #62 is included here.
adds a config package and unit tests to allow Derek to be
configured by a struct. The new struct reads data from env-vars
and from disk including throwing errors when data is missing.
application renamed application_id (env-var)
access_token renamed personal_access_token (env-var) and
documented in GET.md
godoc added to packages / functions
unit tests added for hmacValidation() method
minor version of Golang SDK bumped in Dockerfile
How Has This Been Tested?
Tested through unit tests and go build with Go 1.10.4
Types of changes
Checklist:
git commit -s