chore(v0.6.0): update Cargo.toml & CHANGELOG #97

warning: docs for function returning `Result` missing `# Errors` section --> src/syntax/mod.rs:14:1 | 14 | pub fn parse(text: &str) -> crate::error::Result<ast::Ast> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

docs for function returning `Result` missing `# Errors` section: src/syntax/visitor.rs#L23

warning: docs for function returning `Result` missing `# Errors` section --> src/syntax/visitor.rs:23:5 | 23 | / fn visit_description( 24 | | &mut self, 25 | | description: &ast::Description, 26 | | ) -> Result<Self::Output, Self::Error>; | |___________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

docs for function returning `Result` missing `# Errors` section: src/syntax/visitor.rs#L21

warning: docs for function returning `Result` missing `# Errors` section --> src/syntax/visitor.rs:21:5 | 21 | fn visit_action(&mut self, action: &ast::Action) -> Result<Self::Output, Self::Error>; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

docs for function returning `Result` missing `# Errors` section: src/syntax/visitor.rs#L19

warning: docs for function returning `Result` missing `# Errors` section --> src/syntax/visitor.rs:19:5 | 19 | fn visit_condition(&mut self, condition: &ast::Condition) -> Result<Self::Output, Self::Error>; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

docs for function returning `Result` missing `# Errors` section: src/syntax/visitor.rs#L17

warning: docs for function returning `Result` missing `# Errors` section --> src/syntax/visitor.rs:17:5 | 17 | fn visit_root(&mut self, root: &ast::Root) -> Result<Self::Output, Self::Error>; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

docs for function returning `Result` missing `# Errors` section: src/syntax/tokenizer.rs#L151

warning: docs for function returning `Result` missing `# Errors` section --> src/syntax/tokenizer.rs:151:5 | 151 | pub fn tokenize(&mut self, text: &str) -> Result<Vec<Token>> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

docs for function returning `Result` missing `# Errors` section: src/syntax/semantics.rs#L128

warning: docs for function returning `Result` missing `# Errors` section --> src/syntax/semantics.rs:128:5 | 128 | pub fn analyze(&mut self, ast: &ast::Ast) -> Result<()> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

docs for function which may panic missing `# Panics` section: src/syntax/semantics.rs#L128

warning: docs for function which may panic missing `# Panics` section --> src/syntax/semantics.rs:128:5 | 128 | pub fn analyze(&mut self, ast: &ast::Ast) -> Result<()> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | note: first possible panic found here --> src/syntax/semantics.rs:129:9 | 129 | / match ast { 130 | | Ast::Root(root) => self.visit_root(root), 131 | | Ast::Condition(condition) => self.visit_condition(condition), 132 | | Ast::Action(action) => self.visit_action(action), ... | 136 | | // be stored in `self.errors`. 137 | | .unwrap(); | |_________________^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc

variables can be used directly in the `format!` string: src/syntax/semantics.rs#L84

warning: variables can be used directly in the `format!` string --> src/syntax/semantics.rs:84:17 | 84 | write!(f, "found a condition more than once in lines: {}", lines) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 84 - write!(f, "found a condition more than once in lines: {}", lines) 84 + write!(f, "found a condition more than once in lines: {lines}") |

docs for function returning `Result` missing `# Errors` section: src/syntax/parser.rs#L139

warning: docs for function returning `Result` missing `# Errors` section --> src/syntax/parser.rs:139:5 | 139 | pub fn parse(&mut self, text: &str, tokens: &[Token]) -> Result<Ast> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

this expression creates a reference which is immediately dereferenced by the compiler: src/sol/fmt.rs#L85

warning: this expression creates a reference which is immediately dereferenced by the compiler --> src/sol/fmt.rs:85:49 | 85 | parts.push(self.visit_contract_part(&mut p)?); | ^^^^^^ help: change this to: `p` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

docs for function returning `Result` missing `# Errors` section: src/scaffold/mod.rs#L112

warning: docs for function returning `Result` missing `# Errors` section --> src/scaffold/mod.rs:112:5 | 112 | pub fn scaffold(&self, text: &str) -> crate::error::Result<String> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

docs for function which may panic missing `# Panics` section: src/scaffold/mod.rs#L112

warning: docs for function which may panic missing `# Panics` section --> src/scaffold/mod.rs:112:5 | 112 | pub fn scaffold(&self, text: &str) -> crate::error::Result<String> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | note: first possible panic found here --> src/scaffold/mod.rs:119:25 | 119 | let formatted = fmt(&source).expect("should format the emitted solidity code"); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc

docs for function returning `Result` missing `# Errors` section: src/scaffold/mod.rs#L44

warning: docs for function returning `Result` missing `# Errors` section --> src/scaffold/mod.rs:44:5 | 44 | pub fn run(self) -> anyhow::Result<()> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

docs for function which may panic missing `# Panics` section: src/scaffold/modifiers.rs#L38

warning: docs for function which may panic missing `# Panics` section --> src/scaffold/modifiers.rs:38:5 | 38 | pub fn discover(&mut self, ast: &Ast) -> &IndexMap<String, String> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | note: first possible panic found here --> src/scaffold/modifiers.rs:41:17 | 41 | self.visit_root(root).unwrap(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc

unused `self` argument: src/scaffold/emitter.rs#L77

warning: unused `self` argument --> src/scaffold/emitter.rs:77:29 | 77 | fn emit_contract_header(&self, contract: &hir::ContractDefinition) -> String { | ^^^^^ | = help: consider refactoring to an associated function = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_self = note: `#[warn(clippy::unused_self)]` implied by `#[warn(clippy::pedantic)]`

docs for function returning `Result` missing `# Errors` section: src/hir/mod.rs#L14

warning: docs for function returning `Result` missing `# Errors` section --> src/hir/mod.rs:14:1 | 14 | pub fn translate(tree: &str) -> anyhow::Result<Hir> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

docs for function returning `Result` missing `# Errors` section: src/hir/visitor.rs#L60

warning: docs for function returning `Result` missing `# Errors` section --> src/hir/visitor.rs:60:5 | 60 | / fn visit_comment(&mut self, comment: &hir::Comment) 61 | | -> Result<Self::CommentOutput, Self::Error>; | |____________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

docs for function returning `Result` missing `# Errors` section: src/hir/visitor.rs#L48

warning: docs for function returning `Result` missing `# Errors` section --> src/hir/visitor.rs:48:5 | 48 | / fn visit_function( 49 | | &mut self, 50 | | function: &hir::FunctionDefinition, 51 | | ) -> Result<Self::FunctionDefinitionOutput, Self::Error>; | |_____________________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

docs for function returning `Result` missing `# Errors` section: src/hir/visitor.rs#L37

warning: docs for function returning `Result` missing `# Errors` section --> src/hir/visitor.rs:37:5 | 37 | / fn visit_contract( 38 | | &mut self, 39 | | contract: &hir::ContractDefinition, 40 | | ) -> Result<Self::ContractDefinitionOutput, Self::Error>; | |_____________________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

docs for function returning `Result` missing `# Errors` section: src/hir/visitor.rs#L29

warning: docs for function returning `Result` missing `# Errors` section --> src/hir/visitor.rs:29:5 | 29 | fn visit_root(&mut self, root: &hir::Root) -> Result<Self::RootOutput, Self::Error>; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc = note: `#[warn(clippy::missing_errors_doc)]` implied by `#[warn(clippy::pedantic)]`

module has the same name as its containing module: src/hir/mod.rs#L4

warning: module has the same name as its containing module --> src/hir/mod.rs:4:1 | 4 | pub mod hir; | ^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception = note: `#[warn(clippy::module_inception)]` implied by `#[warn(clippy::all)]`

passing a unit value to a function: src/cli.rs#L25

warning: passing a unit value to a function --> src/cli.rs:25:37 | 25 | Commands::Check(command) => Ok(command.run()), | ^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg = note: `#[warn(clippy::unit_arg)]` implied by `#[warn(clippy::all)]` help: move the expression in front of the call and replace it with the unit literal `()` | 25 ~ Commands::Check(command) => { 26 + command.run(); 27 + Ok(()) 28 ~ }, |

variables can be used directly in the `format!` string: src/check/mod.rs#L145

warning: variables can be used directly in the `format!` string --> src/check/mod.rs:145:13 | 145 | / eprintln!( 146 | | " (run `bulloak check --fix <.tree files>` to apply {} {})", 147 | | fixable_count, fix_literal 148 | | ); | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args = note: `#[warn(clippy::uninlined_format_args)]` implied by `#[warn(clippy::pedantic)]`

docs for function which may panic missing `# Panics` section: src/check/mod.rs#L46

warning: docs for function which may panic missing `# Panics` section --> src/check/mod.rs:46:5 | 46 | pub fn run(self) { | ^^^^^^^^^^^^^^^^ | note: first possible panic found here --> src/check/mod.rs:87:33 | 87 | let formatted = ctx.fmt().expect("should format the emitted solidity code"); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc note: the lint level is defined here --> src/lib.rs:3:22 | 3 | #![warn(clippy::all, clippy::pedantic, clippy::cargo)] | ^^^^^^^^^^^^^^^^ = note: `#[warn(clippy::missing_panics_doc)]` implied by `#[warn(clippy::pedantic)]`

you seem to be trying to use `&Box<T>`. Consider using just `&T`: src/check/violation.rs#L324

warning: you seem to be trying to use `&Box<T>`. Consider using just `&T` --> src/check/violation.rs:324:19 | 324 | contract_sol: &Box<ContractDefinition>, | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&ContractDefinition` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box = note: `#[warn(clippy::borrowed_box)]` implied by `#[warn(clippy::all)]`

this expression creates a reference which is immediately dereferenced by the compiler: src/check/violation.rs#L275

warning: this expression creates a reference which is immediately dereferenced by the compiler --> src/check/violation.rs:275:40 | 275 | let prev_fn = find_matching_fn(&contract_sol, pre_fn_hir); | ^^^^^^^^^^^^^ help: change this to: `contract_sol` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` implied by `#[warn(clippy::all)]`

unneeded `return` statement: src/check/violation.rs#L40

warning: unneeded `return` statement --> src/check/violation.rs:40:9 | 40 | / return matches!( 41 | | self.kind, 42 | | ViolationKind::ContractMissing(_) 43 | | | ViolationKind::ContractNameNotMatches(_, _) 44 | | | ViolationKind::FunctionOrderMismatch(_, _, _) 45 | | | ViolationKind::MatchingFunctionMissing(_, _) 46 | | ); | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return = note: `#[warn(clippy::needless_return)]` implied by `#[warn(clippy::all)]` help: remove `return` | 40 ~ matches!( 41 + self.kind, 42 + ViolationKind::ContractMissing(_) 43 + | ViolationKind::ContractNameNotMatches(_, _) 44 + | ViolationKind::FunctionOrderMismatch(_, _, _) 45 + | ViolationKind::MatchingFunctionMissing(_, _) 46 ~ ) |

the loop variable `j` is only used to index `present_fn_indices`: src/check/rules/structural_match.rs#L155

warning: the loop variable `j` is only used to index `present_fn_indices` --> src/check/rules/structural_match.rs:155:18 | 155 | for j in i + 1..present_fn_indices.len() { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop = note: `#[warn(clippy::needless_range_loop)]` implied by `#[warn(clippy::all)]` help: consider using an iterator | 155 | for <item> in present_fn_indices.iter().skip(i + 1) { | ~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

methods called `from_*` usually take no `self`: src/check/context.rs#L71

warning: methods called `from_*` usually take no `self` --> src/check/context.rs:71:31 | 71 | pub(crate) fn from_parsed(mut self, parsed: Parsed) -> Self { | ^^^^^^^^ | = help: consider choosing a less ambiguous name = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention note: the lint level is defined here --> src/lib.rs:3:9 | 3 | #![warn(clippy::all, clippy::pedantic, clippy::cargo)] | ^^^^^^^^^^^ = note: `#[warn(clippy::wrong_self_convention)]` implied by `#[warn(clippy::all)]`

multiple versions for dependency `yansi`: 0.5.1, 1.0.0-rc.1: src/lib.rs#L1

warning: multiple versions for dependency `yansi`: 0.5.1, 1.0.0-rc.1 | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_crate_versions

multiple versions for dependency `toml_edit`: 0.19.15, 0.20.7, 0.21.0: src/lib.rs#L1

warning: multiple versions for dependency `toml_edit`: 0.19.15, 0.20.7, 0.21.0 | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_crate_versions

multiple versions for dependency `toml`: 0.7.8, 0.8.8: src/lib.rs#L1

warning: multiple versions for dependency `toml`: 0.7.8, 0.8.8 | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_crate_versions

multiple versions for dependency `syn`: 1.0.109, 2.0.39: src/lib.rs#L1

warning: multiple versions for dependency `syn`: 1.0.109, 2.0.39 | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_crate_versions

multiple versions for dependency `socket2`: 0.4.10, 0.5.5: src/lib.rs#L1

warning: multiple versions for dependency `socket2`: 0.4.10, 0.5.5 | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_crate_versions

multiple versions for dependency `proc-macro-crate`: 1.3.1, 2.0.0: src/lib.rs#L1

warning: multiple versions for dependency `proc-macro-crate`: 1.3.1, 2.0.0 | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_crate_versions

multiple versions for dependency `bitflags`: 1.3.2, 2.4.1: src/lib.rs#L1

warning: multiple versions for dependency `bitflags`: 1.3.2, 2.4.1 | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_crate_versions

multiple versions for dependency `alloy-primitives`: 0.3.3, 0.4.2: src/lib.rs#L1

warning: multiple versions for dependency `alloy-primitives`: 0.3.3, 0.4.2 | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_crate_versions note: the lint level is defined here --> src/lib.rs:3:40 | 3 | #![warn(clippy::all, clippy::pedantic, clippy::cargo)] | ^^^^^^^^^^^^^ = note: `#[warn(clippy::multiple_crate_versions)]` implied by `#[warn(clippy::cargo)]`

lint

The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

lint

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

lint