Skip to content
This repository has been archived by the owner on Aug 1, 2020. It is now read-only.

Update antlr version to the latest 4.7.1 #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jumarko
Copy link

@jumarko jumarko commented Jul 19, 2018

Check antlr4 releases - especially escape sequences which now produce warnings (e.g. antlr/antlr4#1717).

@jumarko
Copy link
Author

jumarko commented Jul 24, 2018

@alexhall could you please check this change?

@thierrymarianne
Copy link

thierrymarianne commented Aug 4, 2019

@alexhall Thank you for initiating this plugin! For the time being, I've deployed changes to clojar since the project has not been updated in a while, but I'll gladly revert changes, update the project.clj in accordance with your preferences whenever you would have some time to invest in this again.

@jumarko Fyi, I had to upgrade antl dependency as well via https://github.com/thierrymarianne/lein-antlr-plugin (requiring version 4.7.2).
Have you figured alternate solutions to run antlr, clojure and lein altogether?

@jumarko
Copy link
Author

jumarko commented Aug 5, 2019

@thierrymarianne I'm not sure what you're talking about - I updated the ANTLR version to 4.7.1 and that worked fine for me. You (now) updated it to 4.7.2. Is there something else I'm missing?

@jumarko
Copy link
Author

jumarko commented Aug 5, 2019

Btw. since @alexhall doesn't look to be active perhaps this repo could be moved to https://github.com/clj-commons?

@thierrymarianne
Copy link

thierrymarianne commented Aug 5, 2019

@jumarko Your understanding is correct.
There is nothing more (apart from also having registered this upgraded version of lein-antlr plugin from clojars)

I didn't know about CLJ Commons. Thank you for the link!
From what I can see, there is no Leiningen plugin hosted by this organization though.

Besides, running lein antlr currently writes to the standard output the following warning message

Hooks are deprecated and will be removed in a future version.

I guess one would need to find an alternate solution to keep such a plugin fully functional and compatible with the next versions of Leiningen.

From what I have seen, a cleaning task of the ANTLR target directory is hooked onto the lein clean command and could be removed easily to prevent issues with it in the future.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants