vmaf: Don't force input frame rate. #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the input option `-r` from ffmpeg command and rely on PTS of the respective containers. Add `settb` filter to establish common timebase for different containers. Different timestamp syncing: Use the absolute nearest timestamp for frame selection in libvmaf. Also stop at the end of the shortest stream, which sometimes helps with n_subsample>1 when, for some reason, ffmpeg fails with no score to parse. Both options can be overridden by `--vmaf`. In case the VMAF score obtained using this new approach are lower than expected, adding `--vmaf ts_sync_mode=default` should be tried.
|
Thanks, looks good. I'll do some before/after testing |
|
test-vids all look good Test resultstest-vids/4kmedia-sony-new-york-fashion-demo.mp4main215test-vids/4kmedia-spacex-launch-demo.mp4main215test-vids/pixabay-bridge-23544.mp4main215test-vids/pixabay-elevator-3735.mp4main215test-vids/pixabay-lemon-82602.mp4main215test-vids/pixabay-nature-31377.mp4main215test-vids/pixabay-sunrise-83880.mp4main215test-vids/pixabay-turntable-8453.mp4main215 |
alexheretic
reviewed
Jul 27, 2024
alexheretic
reviewed
Jul 27, 2024
remove commented out lines
|
Note: This has essentially been reverted by #254 since there were reported regressions without it. However, you will be able to toggle the behaviour off if desired. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the input option
-rfrom ffmpeg command and rely on PTS of the respective containers. Addsettbfilter to establish common timebase for different containers.Different timestamp syncing:
Use the absolute nearest timestamp for frame selection in libvmaf. Also stop at the end of the shortest stream, which sometimes helps with n_subsample>1 when, for some reason, ffmpeg fails with no score to parse. Both options can be overridden by
--vmaf.In case the VMAF score obtained using this new approach are lower than expected, adding
--vmaf ts_sync_mode=defaultshould be tried.This is supposed to address some issues (#108, #141) which, this author believes, are due to (periodic) de-synchronization of frames in libvmaf caused by rounding errors in the timestamp calculation. It should also now be possible to compare videos with different frame rates with the help of
--reference-vfilter=fps=<fps(distorted)>, which is an actual use case as @mr44er pointed out.