This repository has been archived by the owner on May 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 243
Rewriting index.coffee.. #87
Open
rlindsberg
wants to merge
5
commits into
alexkirsz:next
Choose a base branch
from
rlindsberg:next
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rlindsberg
commented
Aug 27, 2018
- Add script to build ES6 with babel
- Import module os and list network interfaces
@alexkirsz Hi! Can you check it out if I am doing it right? |
@rlindsberg This is fine :) On the CLI side, I'd recommend reimplementing the current behavior for now. You can consider one PR to be one feature, to be merged once the implementation is complete. |
@alexkirsz Which feature should I work on first? I feel kinda difficult to find somewhere to begin with.. |
@rlindsberg For now, the focus is on translating the codebase from CoffeeScript to JavaScript. So it doesn't really matter which feature you implement first, as long as the new code is functionally equivalent to the old code. |
So I'd say just start with a file (or parts of a file) and translate it 1:1, make a PR and I'll check it out :) |
rlindsberg
changed the title
Little progress implementing babel..
Rewriting index.coffee..
Jul 13, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.