Remove ellipsis dependency + address deprecation warnings #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivroy
changed the title
|
the test-coverage action can be fixed by following steps outlined in r-lib/actions#834 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In favour of rlang since ellipsis is deprecated. https://rlang.r-lib.org/news/index.html#argument-intake-1-0-0
While running tests, I noticed some deprecation warnings, that I took care of
context(..)in tests (the context is now derived from test file name)expect_equivalent(...)->expect_equal(..., ignore_attr = TRUE)aes_string("x", "y")->aes(.data$x, .data$y)(this required me to useusethis::use_import_from("rlang", ".data")as suggested in ggplot2 in packages vignettecovrfrom Suggests, as the test-coverage action installs the package already.