More linting from Biome.js

[alexrudd2]

I am still experimenting with Biome as a faster and simpler alternative to eslint, its mess of plugins, and prettier.

The defaults seem pretty good and match with many eslint plugins. I think a lot of the rules/lints are worth adopting. Even if we ultimately don't use Biome, we can find the corresponding eslint rules.

[alexrudd2]

See also #96. I expect efforts to cleanup with any linter will improve the situation with all of them.

IMO there are three large problems with confidence in refactoring:
(1) lots of any types that need to be narrowed
(2) lack of thorough tests
(3) lack of understanding the actual architecture :)

[alexrudd2]

@drskullster feel free to add your comments as well.

[juli4nb4dillo]

@alexrudd2 I'm assuming it uses the same eslintrc.js?
Otherwise I don't know where it's getting its rules.
If we're adopting biome, it should be in the dev dependencies instead of eslint.

[alexrudd2]

@alexrudd2 I'm assuming it uses the same eslintrc.js? Otherwise I don't know where it's getting its rules.

biome.json comes with a set of recommended rules by default. https://biomejs.dev/guides/getting-started/#configuration

If we're adopting biome, it should be in the dev dependencies instead of eslint.

For now I'm still evaluating it, and don't want to step on others' toes removing eslint. We could also consider ts-standard. Also, there are > 100 issues found with the default rules that remain to be fixed. (So far none of the fixes cause eslint to complain, which suggests the good interop/compatibility.)

[drskullster]

No space between { }, but I expect you're still experimenting with the tool?

[alexrudd2]

Yeah, for now in biome.json the linter is enabled but the formatter is not.

I just tried enabling the formatter (with default settings), and it did change to { Vec }.... but also expanded all the imports on different lines. :/

[drskullster]

@alexrudd2 I think it's a great idea to fix lint issues, I have no opinion on the choice of the tool :)

One thing that'd be nice to look at is unnecessary typings, but I don't know if those tools have rules for that. For example in server.ts we define an interface for the Plotter object here:

saxi/src/server.ts

Lines 158 to 163 in d05fc4c

	interface Plotter {
	prePlot: (initialPenHeight: number) => Promise<void>;
	executeMotion: (m: Motion, progress: [number, number]) => Promise<void>;
	postCancel: (initialPenHeight: number) => Promise<void>;
	postPlot: () => Promise<void>;
	}

But the functions below still have their typings :

saxi/src/server.ts

Line 173 in d05fc4c

async postCancel(initialPenHeight: number): Promise<void> {

which hurts the readability in my opinion.

[jedahan]

I'm all for tools with less configuration options, and would love to see how far we can get with the default styles.

[alexrudd2]

OK, I'll merge these since they're generally code improvements and not fighting the other linters (yet?)