Fix erronous void | null typing #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Alex Ruddick <[email protected]>
|
This tracks, it doesn't make sense to return either void or null, so precedence should go to function or null. Let me test real quick. |
juli4nb4dillo
approved these changes
Feb 23, 2025
|
Thanks! I should keep this in mind when we try debugging the pause issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I'm understanding this correctly, noConfusingVoidType actually caught some typing errors. The entire callback can be
null, not just its return.Leaving this as a PR, since I'm not sure if I understand it fully. Also, I'm curious if this has caused any actual problems, particularly with people reporting pause/unpause not working.