Non-docker friendly README.md #553
Closed
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docker has a high RAM overhead and isn't ideal for lightweight webservers or servers running with limited or cost-based resources like AWS EC2 Added more details catered to non-docker environments - Added note about pyenv - Added missing git clone statement - Added options for controlling port and listening address
|
This PR is doc-only and makes no changes to the codebase |
|
I'm not sure this is necessary. There's no specific need for pyenv (I don't use it), and the HOST and PORT values are the default anyway so this is redundant. |
|
... Doesn't work out of the box with Ubuntu 22's system python packages, hence pyenv. Also you don't have any docs on HOST and PORT, so they weren't redundant, you just never mentioned them. I had to scour your source code for those 2 environment variables. I added these docs so that no other Ubuntu users have to go through 3 hours in frustration troubleshooting a 6 line installation script... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker has a high RAM overhead and isn't ideal for lightweight webservers or servers running with limited or cost-based resources like AWS EC2
Added more details catered to non-docker environments