Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store and send documents modified offline #12

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Bringoff
Copy link

No description provided.

@Bringoff Bringoff self-assigned this Oct 28, 2021
@Bringoff Bringoff mentioned this pull request Oct 28, 2021
@Bringoff
Copy link
Author

@algodave need your thoughts about this initial implementation

var store = openAddedStore();
var added = await store.record(id).get(database);
if (added == null) return null;
return peek(added['endpoint'].toString(), id);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bringoff Why are we using peek() here? Shouldn't added documents be stored and retrieved on the local db?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@algodave right, thanks for pointing that out, I actually intended to use storeGetOne here. Fixed

@Bringoff Bringoff force-pushed the offline-refinements branch from 82813d4 to 9715832 Compare November 3, 2021 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants