Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solved: Algorand Challenge 4 #58

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Pasquale-Silv
Copy link

Fix the Bug Submission Pull Request

What was the bug?

The bug was about the fact that the "addTransaction" method of the "AtomicTransactionComposer" class couldn't take the sender Account as an argument to sign the transactions in the atomic transactions group because the sender is of type "Account" while It takes as argument an object of type "TransactionSigner". The latter is what's needed to sign every transaction added in the atomic transfers transactions group.

How did you fix the bug?

I fixed the bug by applying the function "makeBasicAccountTransactionSigner" on the sender Account, so I created an object of type "TransactionSigner" (this type represents a function which can sign transactions from an atomic transaction group) and then I used this object to sign the two transactions in the atomic transaction group.

Console Screenshot:

image

@iskysun96 iskysun96 added the Approved ✅ Successfully completed the challenge! label Apr 1, 2024
@iskysun96
Copy link
Contributor

🎉 Congrats on solving the 4th Algorand Coding Challenge!

I have labeled your PR approved, so you can now claim your certificate.

You can claim your certificate of completion NFT here:
https://goplausible.xyz/claim/8x3aqnmh7p2wf25dvmxz7ksvjs3gr02d6648tf31ny90wwtams53jvssjwcj2bgfs7qr425958h3abw83a33t3tdbqb0sjtntmta82r

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved ✅ Successfully completed the challenge!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants