tools: Block Generator - allow exporting to files #5656
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzaffi
changed the title
Codecov Report
@@ Coverage Diff @@
## master #5656 +/- ##
==========================================
- Coverage 55.51% 55.50% -0.01%
==========================================
Files 473 473
Lines 66316 66316
==========================================
- Hits 36814 36811 -3
Misses 27005 27005
- Partials 2497 2500 +3 see 14 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tzaffi
changed the title
tzaffi
changed the title
winder
reviewed
Aug 14, 2023
| @@ -46,18 +46,19 @@ func init() { | |||
| RunnerCmd.Flags().StringVarP(&runnerArgs.Path, "scenario", "s", "", "Directory containing scenarios, or specific scenario file.") | |||
| RunnerCmd.Flags().StringVarP(&runnerArgs.ConduitBinary, "conduit-binary", "i", "", "Path to conduit binary.") | |||
| RunnerCmd.Flags().Uint64VarP(&runnerArgs.MetricsPort, "metrics-port", "p", 9999, "Port to start the metrics server at.") | |||
| RunnerCmd.Flags().BoolVarP(&runnerArgs.FileExporterInsteadofPG, "file-exporter-instead-of-pg", "", false, "If set, use the runner will export blocks to files; otherwise, the postgres database is used.") | |||
There was a problem hiding this comment.
consider a "--template-override" option rather than baking in this custom template.
There was a problem hiding this comment.
Introduced the optional --template flag: 2c267aa
shiqizng
previously approved these changes
Aug 25, 2023
Tools blockgen msgp export
|
closing in favor of: #5714 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Block Generator in File Exporting Mode + README + Makefile + Remove Python Runner
The only functional change is to allow exporting blocks into conduit's data directory. This is useful for generating Conduit fixtures.
Non functional changes:
maketargets