Re-add PHOTON_BUILD_DEPENDENCIES in CI workflow #608
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beef9999
force-pushed
the
beef9999/minor-37
branch
from
fd95afb
to
7700f0d
Compare
beef9999
commented
Oct 26, 2024
| if (NOT EXISTS "${URING_LIB_BASE}/liburing.so.${URING_VERSION}") | ||
| message(FATAL_ERROR "Requires liburing ${URING_VERSION}. Install it to system or try -D PHOTON_BUILD_DEPENDENCIES=ON") | ||
| endif () |
There was a problem hiding this comment.
This should fix issues like #476 that users have installed liburing system-wide
beef9999
force-pushed
the
beef9999/minor-37
branch
from
7700f0d
to
78f1301
Compare
beef9999
commented
Oct 26, 2024
| -D PHOTON_ENABLE_FUSE=ON \ | ||
| -D PHOTON_ENABLE_URING=ON \ | ||
| -D PHOTON_ENABLE_EXTFS=ON \ | ||
| -D PHOTON_BUILD_DEPENDENCIES=ON |
There was a problem hiding this comment.
Since we have been using custom image, at least keep one CI to verify PHOTON_BUILD_DEPENDENCIES.
beef9999
force-pushed
the
beef9999/minor-37
branch
6 times, most recently
from
d5071c6
to
f19b113
Compare
beef9999
force-pushed
the
beef9999/minor-37
branch
from
f19b113
to
3cd3468
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.