Add install option for cmake #622
Open
+14
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
beef9999
reviewed
Nov 23, 2024
| ) | ||
| add_dependencies(copy_includes photon_static) | ||
|
|
||
| install(DIRECTORY ${CMAKE_BINARY_DIR}/include/ DESTINATION include) |
There was a problem hiding this comment.
Suggested change
| install(DIRECTORY ${CMAKE_BINARY_DIR}/include/ DESTINATION include) | |
| install(DIRECTORY ${CMAKE_SOURCE_DIR}/include/ DESTINATION include) | |
| install(FILES ${CMAKE_ARCHIVE_OUTPUT_DIRECTORY}/libphoton.a DESTINATION lib) | |
| install(PROGRAMS ${CMAKE_ARCHIVE_OUTPUT_DIRECTORY}/libphoton.so DESTINATION lib) |
There was a problem hiding this comment.
Actually we don't need to copy include dir to build dir? So the copy_includes target is not necessary.
And those depentent static libs have been --whole-archiveed into libphoton.so, so you can just specify the so file to install.
The PROGRAMS is to keep file's executable permissions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
copy include & libs to install directory