feat:add wasm go key-rate-limit plugin #1751
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1751 +/- ##
==========================================
+ Coverage 35.91% 43.41% +7.50%
==========================================
Files 69 76 +7
Lines 11576 12278 +702
==========================================
+ Hits 4157 5331 +1174
+ Misses 7104 6617 -487
- Partials 315 330 +15 |
|
请求review（如果有时间的话） |
| var tokenBucketPrefix string = "mse.token_bucket" | ||
|
|
||
| // Key-prefix for token bucket last updated time. | ||
| var lastRefilledPrefix string = "mse.last_refilled" |
| // Key-prefix for token bucket last updated time. | ||
| var lastRefilledPrefix string = "mse.last_refilled" | ||
|
|
||
| var ruleId int = 0 |
There was a problem hiding this comment.
这个作为 parseConfig 的一个局部变量是不是就够了？
There was a problem hiding this comment.
这里我想请教一下parseConfig在处理不同级别的规则，比如domain和ingress的rule是不是会分别调用parseconfig还是一次性调用，如果一次性调用的话ruleId作为parseConfig的局部变量就可以了。
There was a problem hiding this comment.
这里我想请教一下parseConfig在处理不同级别的规则，比如domain和ingress的rule是不是会分别调用parseconfig还是一次性调用，如果一次性调用的话ruleId作为parseConfig的局部变量就可以了。
不同粒度的配置是独立的解析的，不需要考虑覆盖。
There was a problem hiding this comment.
这里主要是想通过一个全局的ruleId来区分不同粒度下limit_key规则相同的情况，独立接卸的情况下ruleId如果作为parseConfig的一个局部变量是不是没法区分
There was a problem hiding this comment.
请 @johnlanni 看一下这种场景建议如何实现。
| var initialValue uint64 = 0 | ||
| for _, rule := range rules { | ||
| lastRefilledKey := strconv.Itoa(rule.ruleId) + lastRefilledPrefix + rule.key | ||
| tokenBucketKey := strconv.Itoa(rule.ruleId) + tokenBucketPrefix + rule.key |
There was a problem hiding this comment.
感觉可以给LimitItem加个函数生成这两个key
kai2321
force-pushed
the
feat-key-rate-limit
branch
from
43726bd to
c3c2627
Compare
|
PTAL @CH3CHO |
| // Key-prefix for token bucket last updated time. | ||
| var lastRefilledPrefix string = "mse.last_refilled" | ||
|
|
||
| var ruleId int = 0 |
There was a problem hiding this comment.
请 @johnlanni 看一下这种场景建议如何实现。
Ⅰ. Describe what this PR did
实现wasm-go的本地key-rate-limit插件
Ⅱ. Does this pull request fix one issue?
#596
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews