Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gateway log config should read from helm\core\values.yaml when deploy with helm #1834

Merged
merged 3 commits into from
Feb 28, 2025

Conversation

firebook
Copy link
Contributor

Higress describe gateway log config global.proxy.logLevel, global.proxy.componentLogLevel in readme:helm\higress\README.md, but they are invalid.

This PR read log config values from helm\core\values.yaml and set them to helm\core\templates_pod.tpl.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@CLAassistant
Copy link

CLAassistant commented Feb 27, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@CH3CHO CH3CHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是不是都给个默认值更合适一些,哪怕实际配了空

Copy link
Collaborator

@CH3CHO CH3CHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.43%. Comparing base (ef31e09) to head (d9b785c).
Report is 322 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1834      +/-   ##
==========================================
+ Coverage   35.91%   43.43%   +7.52%     
==========================================
  Files          69       76       +7     
  Lines       11576    12278     +702     
==========================================
+ Hits         4157     5333    +1176     
+ Misses       7104     6616     -488     
- Partials      315      329      +14     

see 71 files with indirect coverage changes

@firebook
Copy link
Contributor Author

firebook commented Feb 27, 2025

@CH3CHO Helm Docs / translate-readme (pull_request)
Helm Docs / translate-readme (pull_request)Failing after 9s

这个是跑翻译失败了?

@CH3CHO
Copy link
Collaborator

CH3CHO commented Feb 27, 2025

@CH3CHO Helm Docs / translate-readme (pull_request) Helm Docs / translate-readme (pull_request)Failing after 9s

这个是跑翻译失败了?

#1828 这个合并了之后就好了。不影响。

@CH3CHO CH3CHO merged commit 2d1d8ac into alibaba:main Feb 28, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants