tag_standardization #1828
Merged
tag_standardization #1828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryzhx8
approved these changes
Oct 24, 2024
yyuuttaaoo
reviewed
Oct 25, 2024
core/constants/TagConstants.cpp
Outdated
| const std::string DEFAULT_LOG_TAG_FILE_INODE = "__inode__"; | ||
| const std::string DEFAULT_LOG_TAG_FILE_PATH = "__path__"; | ||
|
|
||
| // 差异部分 |
There was a problem hiding this comment.
这个注释是不是移动到58行后面，写 差异部分End比较好？
yyuuttaaoo
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.