optimize: 1. reserve metric events before parse log events, 2. use SetTagNoCopy in Relabel, 3. optimize the logic of delete labels which starts with "__" #1840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // delete tag __<label_name> | ||
| vector<StringView> toDelete; | ||
| for (const auto& [k, v] : targetTags) { | ||
| if (k.starts_with("__")) { |
There was a problem hiding this comment.
这个特殊判断的什么场景，具体原因是什么？
很多地方都在用__判断，最好封装成一个函数，并注释下原因
There was a problem hiding this comment.
Prom 中以 "__" 开头的 Label 是参加中间 Relabel 过程的，但在最后要删除掉，这次改动是因为之前对每个 MetricEvent 的所有 Tags 都进行了一次遍历，找到对应要删除的再删除。改动后，把它分布到了源头处 TargetLabels 和 MetricRelabel过程中，这样就避免了对 Group 中所有的 MetricEvent 的 Tags 进行全量遍历。
There was a problem hiding this comment.
这种偏特殊处理的，尽量收敛下，封装成函数吧。starts_with("__")
messixukejia
approved these changes
Oct 29, 2024
henryzhx8
approved these changes
Oct 31, 2024
linrunqi08
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
200*5000 场景优化前 181MB、0.733C，优化后150MB、0.686C, 对应18%的内存提升和7%的 CPU 提升