fix: convert chinese log path on windows #1851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
henryzhx8
commented
Nov 2, 2024
•
henryzhx8
commented
- 问题：windows下的logPath需要转码才能显示正常
- 影响：1.8改造的时候就把这个给漏了。因为此问题只有windows才有，而windows从1.6之后没有发过版，因此没有线上影响。
yyuuttaaoo
approved these changes
Nov 5, 2024
| #include "common/ErrorUtil.h" | ||
| #include "common/FileSystemUtil.h" | ||
| #include "common/Flags.h" | ||
| #include "common/HashUtil.h" | ||
| #include "common/RandomUtil.h" | ||
| #include "common/TimeUtil.h" | ||
| #include "common/UUIDUtil.h" | ||
| #include "constants/Constants.h" |
There was a problem hiding this comment.
因为没有版本所以没法测试，先跟太业讲下，由他来跟踪下吧
messixukejia10
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.