Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change metric struct #1862

Merged
merged 9 commits into from
Nov 13, 2024
Merged

Conversation

Takuka0311
Copy link
Collaborator

No description provided.

core/monitor/LogtailMetric.cpp Outdated Show resolved Hide resolved
core/monitor/metric_constants/PluginMetrics.cpp Outdated Show resolved Hide resolved
core/monitor/metric_constants/ComponentMetrics.cpp Outdated Show resolved Hide resolved
@messixukejia
Copy link
Collaborator

image
time这个字段有实际作用吗?跟__time__是不是重了

@Takuka0311
Copy link
Collaborator Author

image time这个字段有实际作用吗?跟__time__是不是重了

这个time是指标输出到文件时有的字段,是标识日志记录的时间,如果是输出到sls会直接set到__time__。现在这些数据是我采集的文件,所以会同时存在time和__time__

@messixukejia
Copy link
Collaborator

image time这个字段有实际作用吗?跟__time__是不是重了

这个time是指标输出到文件时有的字段,是标识日志记录的时间,如果是输出到sls会直接set到__time__。现在这些数据是我采集的文件,所以会同时存在time和__time__

设置完就delete吧

@Takuka0311
Copy link
Collaborator Author

ut的报错是 #1868 引入的,他在修了

@Takuka0311 Takuka0311 merged commit eaf69cb into alibaba:main Nov 13, 2024
8 checks passed
@henryzhx8 henryzhx8 added the enhancement Feature enhancement label Nov 13, 2024
@henryzhx8 henryzhx8 added this to the v2.2 milestone Nov 13, 2024
@Takuka0311 Takuka0311 deleted the feat/rename-metrics branch November 28, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants