Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the problem of increasing container meta information in Docker Center and add UT to this module #1938

Merged
merged 4 commits into from
Dec 16, 2024
Merged

Fix the problem of increasing container meta information in Docker Center and add UT to this module #1938

merged 4 commits into from
Dec 16, 2024

Conversation

linrunqi08
Copy link
Collaborator

@linrunqi08 linrunqi08 commented Dec 2, 2024 •
edited
Loading

  1. 修复之前标准输出C++话引入的finished时间，该时间逻辑为无效逻辑
  2. 修复docker center fetchAll函数返回error问题，现在只有containerList才会返回error，单次inspect失败不会返回error
  3. 修复docker center fetchAll不断重试导致的docker.sock和containerd.sock连接泄漏的问题
  4. docker compose场景标准输出采集问题，改成从input_stdout入口进行修复，对于logPath为空的容器信息，不创建reader，待下次获取完整容器信息时候，创建reader，已手动测试过

@linrunqi08 linrunqi08 force-pushed the feature/taiye/add_docker_test branch 2 times, most recently from a552757 to e78ef73 Compare December 9, 2024 06:07
@linrunqi08 linrunqi08 force-pushed the feature/taiye/add_docker_test branch from 46adff8 to 35258d0 Compare December 16, 2024 01:19
@linrunqi08
Merge branch 'main' of https://github.com/alibaba/ilogtail into featu…
093b01c 
…re/taiye/add_docker_test

Conflicts:
	pkg/helper/docker_center.go
@linrunqi08 linrunqi08 merged commit 1a59190 into main Dec 16, 2024
15 checks passed
linrunqi08 added a commit that referenced this pull request Dec 16, 2024
@linrunqi08
Fix the problem of increasing container meta information in Docker Ce…
2742837 
…nter and add UT to this module (#1938)

* refine docker center code

* fix comments

* fix comments
Conflicts:
	pkg/helper/docker_center.go
@linrunqi08 linrunqi08 mentioned this pull request Dec 16, 2024
Merged
linrunqi08 added a commit that referenced this pull request Dec 16, 2024
@linrunqi08
[backport]: Fix the problem of increasing container meta information …
48d786a 
…in Docker Center and add UT to this module (#1938) (#1969)

* refine docker center code

* fix comments

* fix comments
Conflicts:
	pkg/helper/docker_center.go
@henryzhx8 henryzhx8 added the bug Something isn't working label Dec 25, 2024
@henryzhx8 henryzhx8 added this to the v3.0 milestone Dec 25, 2024
@henryzhx8 henryzhx8 deleted the feature/taiye/add_docker_test branch December 28, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quzard quzard quzard approved these changes

@messixukejia messixukejia messixukejia approved these changes

@yyuuttaaoo yyuuttaaoo yyuuttaaoo approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v3.0
Development

Successfully merging this pull request may close these issues.
5 participants
@linrunqi08 @yyuuttaaoo @messixukejia @quzard @henryzhx8