fix: use released pipeline pointer #1978
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
问题
问题一
Flusher在OnSendDone中会将item从队列中移出,后续由于Pipeline被释放,所以导致访问空指针。
修复:在处理之前,先持有Pipeline对象,避免其被释放。
问题二
配置变更时,ProcessRunner在处理完旧Pipeline残留在处理队列的数据时,再将其塞入到发送队列或者Go流水线。
修复:在处理完之后,统一走新流水线发送数据。
测试
后续在配置变更测试中,统一补充测试用例。