fix: flusher_otlp stop nil log/metric/trace client #1994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I8948322d1e54a61c7b17968a5bcaf5590d9a437c
Abingcbc
approved these changes
Dec 26, 2024
|
This PR aims to fix #1995 |
yyuuttaaoo
reviewed
Dec 27, 2024
| @@ -160,21 +160,21 @@ func (f *FlusherOTLP) IsReady(projectName string, logstoreName string, logstoreK | |||
| func (f *FlusherOTLP) Stop() error { | |||
| var err error | |||
|
|
|||
| if f.logClient.grpcConn != nil { | |||
| if f.logClient != nil && f.logClient.grpcConn != nil { | |||
There was a problem hiding this comment.
简洁一些？if f.logClient == nil { return }
There was a problem hiding this comment.
还不行，除了 log 还有 trace，metrics 的 client
There was a problem hiding this comment.
这里用户可能 trace/metrics/log 是三个不同的后端，或者用户只上报一部分数据。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I8948322d1e54a61c7b17968a5bcaf5590d9a437c