Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AsynHttpRequest constructor parameter order. #1998

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −3
Open

Fix AsynHttpRequest constructor parameter order. #1998

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d712b08
fix AsynHttpRequest constructor
linrunqi08 Dec 27, 2024
e67e332
fix build
linrunqi08 Dec 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/common/http/HttpRequest.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,9 +97,9 @@ struct AsynHttpRequest : public HttpRequest {
const std::string& query,
const std::map<std::string, std::string>& header,
const std::string& body,
HttpResponse&& response = HttpResponse(),
uint32_t timeout = static_cast<uint32_t>(INT32_FLAG(default_http_request_timeout_secs)),
uint32_t maxTryCnt = static_cast<uint32_t>(INT32_FLAG(default_http_request_max_try_cnt)),
HttpResponse&& response = HttpResponse(),
bool followRedirects = false,
std::optional<CurlTLS> tls = std::nullopt)
: HttpRequest(
Expand Down
2 changes: 1 addition & 1 deletion core/prometheus/async/PromHttpRequest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@ PromHttpRequest::PromHttpRequest(const std::string& method,
query,
header,
body,
std::move(response),
timeout,
maxTryCnt,
std::move(response),
followRedirects,
std::move(tls)),
mFuture(std::move(future)),
Expand Down
2 changes: 1 addition & 1 deletion core/runner/sink/http/HttpSinkRequest.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ struct HttpSinkRequest : public AsynHttpRequest {
uint32_t timeout = static_cast<uint32_t>(INT32_FLAG(default_http_request_timeout_secs)),
uint32_t maxTryCnt = static_cast<uint32_t>(INT32_FLAG(default_http_request_max_try_cnt))
)
: AsynHttpRequest(method, httpsFlag, host, port, url, query, header, body, HttpResponse(), timeout, maxTryCnt), mItem(item) {}
: AsynHttpRequest(method, httpsFlag, host, port, url, query, header, body, timeout, maxTryCnt), mItem(item) {}

bool IsContextValid() const override { return true; }
void OnSendDone(HttpResponse& response) override {}
Expand Down
Loading