Skip to content

Commit

Permalink
Merge pull request #1 from ShengtongZhu/minrtt-log
Browse files Browse the repository at this point in the history
Fix bug: when skip_path, log message is wrong
  • Loading branch information
ShengtongZhu authored Nov 29, 2023
2 parents b9d272f + f4f46fc commit e75c63f
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions src/transport/scheduler/xqc_scheduler_minrtt.c
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,8 @@ xqc_minrtt_scheduler_get_path(void *scheduler,
path = xqc_list_entry(pos, xqc_path_ctx_t, path_list);

path_class = xqc_path_get_perf_class(path);

path_srtt = xqc_send_ctl_get_srtt(path->path_send_ctl);
path_can_send = xqc_scheduler_check_path_can_send(path, packet_out, check_cwnd);
/* skip inactive paths */
/* skip frozen paths */
if (path->path_state != XQC_PATH_STATE_ACTIVE
Expand All @@ -74,7 +75,6 @@ xqc_minrtt_scheduler_get_path(void *scheduler,
* work well for MPQUIC due to the problem of applimit. We may adapt this
* to BBR in the future, if we manage to fix the applimit problem of BBR.
*/
path_can_send = xqc_scheduler_check_path_can_send(path, packet_out, check_cwnd);

if (!path_can_send) {
goto skip_path;
Expand All @@ -84,7 +84,6 @@ xqc_minrtt_scheduler_get_path(void *scheduler,
*cc_blocked = XQC_FALSE;
}

path_srtt = xqc_send_ctl_get_srtt(path->path_send_ctl);

if (best_path[path_class] == NULL
|| path_srtt < best_path[path_class]->path_send_ctl->ctl_srtt)
Expand Down

0 comments on commit e75c63f

Please sign in to comment.