make attachment to all links opt-in #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
I kind of agree with this, but it is also quite a change to the usage of this library. I don't want people to update their version and find they need to change it, especially that it is easy to just include the script in a page without writing more code which was the original intent, for people who don't (want to) write any JS. Instead, I can imagine a different import - maybe smoothscrollAPI.js - to only import the API without automatically attaching it to links. What do you think? |
|
That sounds fine to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code that attaches to all links is throwing an exception on my site. Besides, I didn't want that automatically; I just wanted to be able to call smoothScroll programmatically. In my opinion attaching smooth scrolling to all links should be an opt-in feature, not the default.