calendar v8 2 1 x #47
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the same way adding it at the v8 version of the module. Only difference: reconstruction of the configuration file (in CmsCsvExportBean.java) is adjusted. Details: - Added CSV-Export configuration facility - Renamed CmsCvsExportBean to CmsCsvExportBean and adjusted calls - Refactored CmsCsvExportBean" This reverts commit 9a18a24.
… webforms in the V8-version. Details: - Renaming of CmsCvsExportBean.java to CmsCsvExportBean.java and necessary adjustments in the calling JSPs. - new option for the configuration in the form.xsd - added handling for the new option to CmsForm.java - a lot of refactoring in CmsCsvExportBean.java - increased version number to 2.2.0" This reverts commit 5726d9a.
increased version number to 2.0.1
Using gradle 2.1 the build script fails with the following message:
[Fatal Error] SerialDateWidget.gwt.xml:2:10: DOCTYPE is disallowed when the feature "http://apache.org/xml/features/disallow-doctype-decl" set to true.
The build script uses the default XmlParser. This is 'a non-validating and non-namespace-aware XmlParser which does not allow DOCTYPE declarations in documents'. Correcting it to use a parser that does allow DOCTYPE declarations still tries to fetch an external DTD and fails with a:
[Fatal Error] SerialDateWidget.gwt.xml:2:172: External DTD: Failed to read external DTD 'gwt-module.dtd', because 'http' access is not allowed due to restriction set by the accessExternalDTD property.
Setting the `load-external-dtd` feature to false fixes the failure.
...erroneously copied when creating patch
Groovy < 2.1.9 doesnt have the XmlParser(boolean,boolean,boolean) constructor. For these groovy versions, the default XmlParser() returns an appropriate parser that needs not be tuned.
opencms-core has extended interface I_CmsResourceCollector with a new method signature. This commit is a workaround to allow compiling the outdated alkacon-oamp sources.
With Java 8, the build fails with the message `Execution failed for task ':javadoc_com.alkacon.opencms.calendar'`. This patch ignores javadoc errors during the build for Java 8+.
Log follows (warnings skipped):
````
[...]/alkacon-oamp/com.alkacon.opencms.calendar/src/com/alkacon/opencms/calendar/CmsSerialDateSelectWidget.java:64: error: unknown tag: layout
* <code><layout element="Change" widget="SerialDateSelectWidget" configuration="property:calendar.startdate|count:25" /></code>.<p>
^
[...]
:javadoc_com.alkacon.opencms.calendar
1 error
22 warnings
:javadoc_com.alkacon.opencms.calendar FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':javadoc_com.alkacon.opencms.calendar'.
````
With Java 8 the compilation breaks with an "incompatible types" error.
Error log follows:
````
alkacon-oamp/com.alkacon.opencms.v8.comments/src/com/alkacon/opencms/v8/comments/CmsCommentsAccess.java:1019: error: incompatible types: Object cannot be converted to Entry<String,String[]>
for (Map.Entry<String, String[]> entry : CmsRequestUtil.createParameterMap(req.getParameterMap()).entrySet()) {
^
Note: [...]/alkacon-oamp/com.alkacon.opencms.v8.comments/src/com/alkacon/opencms/v8/comments/CmsCommentsAccess.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
1 error
:compileComAlkaconOpencmsV8CommentsJava FAILED
````
…n-oamp into branch_9_5_x
…n-oamp into branch_9_5_x
Delete default group "Projectmanagers"
…n-oamp into branch_9_5_x
…n-oamp into branch_9_5_x
Delete default group "Projectmanagers"
…n-oamp into branch_9_5_x
According to commit alkacon/opencms-core@210fa97
…n-oamp into branch_9_5_x
Update and fix fullcalendar client code. Use existing localization from fullcalendar.js + moment.js. Comment out qtip code: doesn't work properly.
Following error is thrown during the gwt_ build:
Execution failed for task ':gwt_com.alkacon.opencms.v8.calendar'.
> Cannot convert the provided notation to a File or URI: true.
The following types/formats are supported:
- A String or CharSequence path, e.g 'src/main/java' or '/usr/include'
- A String or CharSequence URI, e.g 'file:/usr/include'
- A File instance.
- A URI or URL instance.
Return the this instance if possible to allow chaining method calls.
There has been several big refactoring actions in opencms-core (e.g. opencms-core#62ee10715bb60b5888aa7cdb380ed261ff6388fe).
and qualify return types.
and make it private
on possible code improvements
|
I have tried to change as little as possible to avoid breaking existing code. There are still some quirks regarding the ADE editor for serial dates. Please, be aware that I'm not an OpenCms expert and I could have broken some OpenCms patterns that I'm not aware of. Be cautious if importing these changes into production code. |
Add missing dependency: acacia-editor
(was fix 'Cannot convert the provided notation')
mimmicking the bootstrap demo module v 9.5.2
to provide support for ADE
…h_9_5_x__v8_calendar_2_1_x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make calendar v8 compile and upgrade calendar view to use fullcalendar v2.3.1.