Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quick-repeat-list interpolation #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

llchan
Copy link

@llchan llchan commented Dec 5, 2013

This adds simple interpolation of the quick-repeat-list variable. There may be a better way to do this but this worked for my case. It is important to note that the variable is not watched like a typical interpolated attribute. We may want to add that option in the future.

#9

@allaud
Copy link
Owner

allaud commented Dec 6, 2013

I'll check it in the next couple of days

@allaud
Copy link
Owner

allaud commented Dec 10, 2013

@llchan can you also add these changes to the quick-ng-script in example directory?

@allaud
Copy link
Owner

allaud commented Dec 21, 2013

Hey @llchan what about my suggestion? I want to merge this as soon as possible

@llchan
Copy link
Author

llchan commented Dec 22, 2013

Should I just update the example to be functionally the same but have an interpolated list name internally? In practice you probably wouldnt use it unless you have at least 2 lists to render but I dont know if we want to change up the example so much.

@allaud
Copy link
Owner

allaud commented Dec 22, 2013

@llchan actually we don't. Let's just make it the same file

@rubensayshi
Copy link

If I manually merge this should this support a nested ng-repeat too ?

Because the below snippet doesn't work for me (with or without manually merging this PR)

<div ng-repeat="item in mylist">
    <div quick-ng-repeat="child in list" quick-repeat-list="item.children">{{ child.title }}</div>
</div>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants