Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made quick-ng-repeat work with jshint #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Made quick-ng-repeat work with jshint #23

wants to merge 1 commit into from

Conversation

Rastii
Copy link

@Rastii Rastii commented Jan 12, 2015

When I attempted to add this module into an existing angular project, I noticed a ton of errors/warnings using JSHint.

This pull request simply makes JSHint not scream at the code with the following changes:

  • Removed unnecessary semicolons after function declarations.
  • Added missing brackets in conditional statements.
  • Added missing semi colons for closure function declarations.
  • Removed a few function declarations within loops.

As for the function declarations within loops, please let me know if I should change them, I honestly didn't review the code to a full extent; therefore, I wouldn't know the best naming conventions for said anonymous functions.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant