Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 즐겨찾기 기능을 구현한다. #50
feat: 즐겨찾기 기능을 구현한다. #50
Changes from 5 commits
8ccebbf
af4072f
fbf51f5
61e3849
86ac01c
45b531b
25ad7db
3d5cbef
fbd0f1f
afe73d9
c30e844
243bb0f
8d9693b
1dc19d8
4a0c297
1461ca1
0e586ce
3c3dec7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 76 in src/test/java/kr/allcll/seatfinder/star/StarServiceTest.java
StarServiceTest.즐겨찾기가 5개 이상일 경우 예외를 검증한다.
Raw output
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
expectedExceptionMessage를 문자열 하드코딩하는 것은 어떨까요? 위랑 다르네요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
위와 다르네요 가 어떤 말일까요..?
어느 위를 말하는걸까요???
어떤 말을 하는지 잘 이해가 안가는데 다시 한번 설명해주실 수 있으실까용
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
바로 위에 있는 테스트 78번 라인을 보면
라고 되어 있어요. 하지만 이 테스트는 Exception 객체를 생성하고 거기에서 예외 메시지를 뽑아내고 있어요. 일관성이 안 맞아서 남긴 코멘트였어요.