Feature/flip volume #184
Merged
Feature/flip volume #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toloudis
force-pushed
the
feature/flip-volume
branch
from
299f872 to
fe215d0
Compare
toloudis
commented
May 6, 2024
renderlib/json/json.hpp
Outdated
There was a problem hiding this comment.
can disregard diff in this file as it is a third party include which I updated
toloudis
commented
May 10, 2024
| lights, | ||
| capture, | ||
| showScaleBar) | ||
| NLOHMANN_DEFINE_TYPE_INTRUSIVE_WITH_DEFAULT(ViewerState, |
There was a problem hiding this comment.
comment why this macro is here and why it usees WITH_DEFAULT
toloudis
commented
May 10, 2024
renderlib/ImageXYZC.cpp
Outdated
| } | ||
|
|
||
| void | ||
| ImageXYZC::setVolumeAxesFlipped(float x, float y, float z) |
There was a problem hiding this comment.
this really should be storing ints or booleans
meganrm
reviewed
May 10, 2024
| @@ -369,6 +384,34 @@ QAppearanceSettingsWidget::createSkyLightingControls() | |||
| return section; | |||
| } | |||
|
|
|||
| void | |||
| QAppearanceSettingsWidget::OnFlipX(bool value) | |||
There was a problem hiding this comment.
just making a note of my suggestion to change these 3 functions to one that takes in an axis value to reduce the copied code
meganrm
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Estimated time to review: ~15 min ? A lot of code changes but all small.
Allows users to flip (mirror / invert) each of the three x,y,z axes for the volume.
The internal storage uses -1 for a flipped axis, and 1 for an unflipped one.
The volume sampling shader has to switch its sampling wrap mode to "REPEAT" to make this work.
When adding a new feature like this, we need to make sure the feature is implemented in json save files (serialization), python script output, as well as client/server communication (aka Commands).
In order to make it easier to add new serialized variables, without having to bump versions, I had to upgrade the json library I am using. Disregard changes to json.hpp as it is a third party file.