add clip plane changes #230
Conversation
…l-animated/agave into feature/add-clip-plane # Conflicts: # renderlib/io/CMakeLists.txt
toloudis
requested review from
meganrm and
ShrimpCryptid
and removed request for
a team
| float denom = dot(R.m_D, g_clipPlane.xyz); | ||
| if (abs(denom) > 0.0001f) // your favorite epsilon | ||
| { | ||
| float tClip = dot(g_clipPlane.xyz*(-g_clipPlane.w) - R.m_O, g_clipPlane.xyz) / denom; | ||
| if (denom < 0.0f) { | ||
| pNearT = max(pNearT, tClip); | ||
| } | ||
| else { | ||
| pFarT = min(pFarT, tClip); | ||
| } | ||
| } |
There was a problem hiding this comment.
Might ask you this in-person, but can you walk me through what this calculation is doing?
There was a problem hiding this comment.
I started to type out a text explanation but it was getting long so in person will be more efficient. If you know how ray-plane intersection works that's most of what you are seeing here, and then some logic to combine the ray-plane intersection with the ray-boundingbox intersection.
| ClipPlaneTool(Plane plane, glm::vec3& pos) | ||
| : ManipulationTool(0) | ||
| , m_plane(plane) | ||
| , m_pos(pos) | ||
| { | ||
| // assumes pos is in plane! if not, there will be trouble. | ||
| // assert(glm::dot(m_plane.normal, m_pos) == m_plane.d); | ||
| } |
There was a problem hiding this comment.
Would it make sense to like, project m_pos onto the provided plane?
There was a problem hiding this comment.
I think the pos data stored by the clip plane tool doesn't have to precisely match the m_plane anymore. At init, I forget why I commented this out (and it may just be because I needed an epsilon). I'll have to put the code back and see why.
Resolves #228
Add user clipping plane functionality.
Also adds some basic UI for enabling, showing/hiding, and manipulating the clip plane but the UI will be more or less completely redone. See #233
Note: gh-actions build is broken on windows but due to dependencies and not this code change.