generated from allen-cell-animated/github-boilerplate
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: AWS Deployment #282
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShrimpCryptid
added
new feature
New feature or request
internals
Tech debt, refactoring, dependencies, etc.
labels
Mar 22, 2024
|
Coverage Report
File CoverageNo changed files found. |
ShrimpCryptid
requested review from
frasercl and
rugeli
and removed request for
a team
March 22, 2024 21:50
griffinfujioka
approved these changes
Mar 22, 2024
griffinfujioka
had a problem deploying
to
staging
March 22, 2024 21:56 — with
GitHub Actions
Failure
ShrimpCryptid
requested review from
toloudis
and removed request for
frasercl and
rugeli
March 22, 2024 22:06
toloudis
approved these changes
Mar 22, 2024
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Updates #279 to push the build files to the S3 bucket, based on @griffinfujioka's template!
Test staging deploy is available here: https://staging.timelapse.allencell.org
Solution
build
job to the GitHub action, which creates the build files and saves them as an artifact.deploy
job to retrieve and sync the build files to S3.(This is how we are currently doing it for GitHub pages!)
Type of change