Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: AWS Deployment #282

Merged
merged 4 commits into from
Mar 22, 2024
Merged

feature: AWS Deployment #282

merged 4 commits into from
Mar 22, 2024

Conversation

ShrimpCryptid
Copy link
Contributor

@ShrimpCryptid ShrimpCryptid commented Mar 22, 2024

Problem

Updates #279 to push the build files to the S3 bucket, based on @griffinfujioka's template!

Test staging deploy is available here: https://staging.timelapse.allencell.org

Solution

  • Adds an extra build job to the GitHub action, which creates the build files and saves them as an artifact.
  • Updates the deploy job to retrieve and sync the build files to S3.
    (This is how we are currently doing it for GitHub pages!)

Type of change

  • New feature (non-breaking change which adds functionality)

@ShrimpCryptid ShrimpCryptid added new feature New feature or request internals Tech debt, refactoring, dependencies, etc. labels Mar 22, 2024
@ShrimpCryptid ShrimpCryptid self-assigned this Mar 22, 2024
Copy link

github-actions bot commented Mar 22, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-03-22 23:04 UTC

Copy link

github-actions bot commented Mar 22, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 66.53% 4192 / 6300
🔵 Statements 66.53% 4192 / 6300
🔵 Functions 53.59% 97 / 181
🔵 Branches 80.5% 322 / 400
File CoverageNo changed files found.
Generated in workflow #782

@ShrimpCryptid ShrimpCryptid marked this pull request as ready for review March 22, 2024 21:50
@ShrimpCryptid ShrimpCryptid requested a review from a team as a code owner March 22, 2024 21:50
@ShrimpCryptid ShrimpCryptid requested review from frasercl and rugeli and removed request for a team March 22, 2024 21:50
@ShrimpCryptid ShrimpCryptid requested review from toloudis and removed request for frasercl and rugeli March 22, 2024 22:06
@ShrimpCryptid ShrimpCryptid merged commit c6b4367 into main Mar 22, 2024
4 checks passed
@ShrimpCryptid ShrimpCryptid deleted the feature/aws-build-and-deploy branch March 22, 2024 23:03
@ShrimpCryptid ShrimpCryptid linked an issue Mar 26, 2024 that may be closed by this pull request
@ShrimpCryptid ShrimpCryptid mentioned this pull request Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internals Tech debt, refactoring, dependencies, etc. new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deployment
3 participants