feature: Show vector values in tooltip #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
ShrimpCryptid
requested review from
meganrm,
ascibisz and
interim17
and removed request for
a team and
ascibisz
interim17
approved these changes
Nov 26, 2024
meganrm
reviewed
Dec 3, 2024
src/Viewer.tsx
Outdated
| <p key="vector_components"> | ||
| {vectorName}: ({numberToStringDecimal(motionDelta[0], 3, allowIntegerTruncation)},{" "} | ||
| {numberToStringDecimal(motionDelta[1], 3, allowIntegerTruncation)}) px | ||
| </p> |
There was a problem hiding this comment.
I don't typically like to have this much data grooming mixed up with rendering. I think this would be a lot easier to follow if you had a separate function that checked for and got the appropriate data and another one that created the
and pushed it to the array.
meganrm
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Closes #473, "Show vector values in tooltip".
Estimated review size: small, 10 minutes
Solution
Type of change
Steps to Verify:
Screenshots (optional):
Magnitude + angle:
Components:
