feature: Toggle backdrop visibility #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShrimpCryptid
added
new feature
|
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
ShrimpCryptid
commented
Dec 2, 2024
Comment on lines
+34
to
+59
| function TooltipWithSubtext( | ||
| props: TooltipProps & { title: ReactNode; subtitle?: ReactNode; subtitleList?: ReactNode[] } | ||
| ): ReactElement { | ||
| const divRef = useRef<HTMLDivElement>(null); | ||
| return ( | ||
| <Tooltip | ||
| {...props} | ||
| title={ | ||
| <> | ||
| <p style={{ margin: 0 }}>{props.title}</p> | ||
| <p style={{ margin: 0, fontSize: "12px" }}>{props.subtext}</p> | ||
| </> | ||
| } | ||
| > | ||
| {props.children} | ||
| </Tooltip> | ||
| <div ref={divRef}> | ||
| <Tooltip | ||
| {...props} | ||
| trigger={["hover", "focus"]} | ||
| title={ | ||
| <> | ||
| <p style={{ margin: 0 }}>{props.title}</p> | ||
| {props.subtitle && <p style={{ margin: 0, fontSize: "12px" }}>{props.subtitle}</p>} | ||
| {props.subtitleList && | ||
| props.subtitleList.map((text, i) => ( | ||
| <p key={i} style={{ margin: 0, fontSize: "12px" }}> | ||
| {text} | ||
| </p> | ||
| ))} | ||
| </> | ||
| } | ||
| getPopupContainer={() => divRef.current ?? document.body} | ||
| > | ||
| {props.children} | ||
| </Tooltip> | ||
| </div> |
There was a problem hiding this comment.
Recommend reviewing this with whitespace off!
ShrimpCryptid
requested review from
interim17 and
rugeli
and removed request for
a team
interim17
approved these changes
Dec 4, 2024
rugeli
reviewed
Dec 5, 2024
| canv.setBackdropBrightness(props.config.backdropBrightness); | ||
| canv.setBackdropSaturation(props.config.backdropSaturation); | ||
| }, [props.selectedBackdropKey, props.config.backdropBrightness, props.config.backdropSaturation]); | ||
| if (props.selectedBackdropKey !== null && props.config.backdropVisible) { |
There was a problem hiding this comment.
This is a nice and important check to have!
rugeli
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
LGTM! Thank you for the demo and the always-helpful comments.
I noticed that clicking outside the checkbox (while hovering over the same row) still toggles it in Viewer Settings. This feels like something a user might accidentally trigger. Are we planning to address this in upcoming PRs?
It's semi-addressed in issue #472, but it's on hold for now pending a redesign of the settings area in #486. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Closes #480, "make background image toggle more visible"!
This change adds a new onscreen toggle for the backdrop image to help make it more discoverable for users.
Estimated review size: ~20 minutes, medium
Solution
ViewerConfigtype.SettingsTabwith the new vector config.CanvasWrapper.Type of change
Steps to Verify:
Screenshots (optional):
Video Talk-through (🔊):
2024-12-02.14-35-36.mp4