feature: Sync vector state to URL #488
Conversation
…n't have backdrops
|
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
ShrimpCryptid
changed the base branch from
main
to
feature/onscreen-backdrops-toggle
ShrimpCryptid
requested review from
toloudis and
ascibisz
and removed request for
a team
| @@ -56,6 +59,12 @@ enum UrlParam { | |||
| SCATTERPLOT_Y_AXIS = "scatter-y", | |||
| SCATTERPLOT_RANGE_MODE = "scatter-range", | |||
| OPEN_TAB = "tab", | |||
| SHOW_VECTOR = "vc", | |||
| VECTOR_KEY = "vc-key", | |||
There was a problem hiding this comment.
is this the "feature name"?
There was a problem hiding this comment.
Yup, it's the equivalent!
| return isHexColor(value) ? new Color(value) : undefined; | ||
| } | ||
|
|
||
| function decodeFloat(value: string | null): number | undefined { |
There was a problem hiding this comment.
how do we not already have these functions in this codebase? surprising!
|
When I was playing around on the preview link, almost everything was working as I would expect (just the basic changing something in the vector arrows menu, seeing the change in the UI, seeing that change in the URL, refreshing with that URL, seeing the state had been preserved in the UI because of the URL). However, when I un-check "Show vector arrows", I see the change in the UI, but I don't see the change in the URL, so of course when I refresh, the vector arrows are back again and the box is checked again. Is this expected? And is this happening for you too on the preview link? |
Oh interesting, I'm seeing that behavior too. Let me debug this and I'll re-request you. |
Problem
Closes #471, "sync vector state to URL."
Estimated review size: small, 15 minutes
Solution
url_utilsparsing.Type of change
Steps to Verify: