fix: Make PR preview link consistent #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage Report
File CoverageNo changed files found. |
ShrimpCryptid
requested review from
toloudis and
frasercl
and removed request for
a team
frasercl
approved these changes
Dec 5, 2024
toloudis
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently there's a GitHub action that builds two previews for the app, one in its public version and one for an internal version w/ experimental features. Before, both jobs were run at the same time, resulting in a race condition where the PR comment would either have the preview or the internal version randomly.
This change orders the steps so the standard, public build preview is always built last, and overrides the internal link. You can still access the internal version by adding
-internalto a PR preview link:Estimated review size: tiny, 1 minute