refactor: Moved hover tooltip rendering logic into component #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit c8e5170)
…overTooltip, renamed state values for clarity
|
Coverage Report
File CoverageNo changed files found. |
ShrimpCryptid
commented
Dec 6, 2024
Comment on lines
+203
to
+204
| const [lastValidHoveredId, setLastValidHoveredId] = useState<number>(-1); | ||
| const [showObjectHoverInfo, setShowObjectHoverInfo] = useState(false); |
There was a problem hiding this comment.
-1 is okay here as a placeholder value, because showObjectHoverInfo is only set to true when lastValidHoveredId can be set to a valid ID number.
There was a problem hiding this comment.
since you called this out, it's definitely odd to call it a "valid" hovered id when -1 is allowed!
ShrimpCryptid
commented
Dec 6, 2024
| } | ||
| }; | ||
|
|
||
| // TODO: Move to a separate component? |
ShrimpCryptid
commented
Dec 6, 2024
Comment on lines
+9
to
+16
| type CanvasHoverTooltipProps = { | ||
| dataset: Dataset | null; | ||
| featureKey: string; | ||
| lastValidHoveredId: number; | ||
| showObjectHoverInfo: boolean; | ||
| motionDeltas: Float32Array | null; | ||
| config: ViewerConfig; | ||
| }; |
There was a problem hiding this comment.
We could really use redux or a state management framework here...
ShrimpCryptid
commented
Dec 6, 2024
Comment on lines
19
to
29
| const TooltipCard = styled.div` | ||
| font-family: var(--default-font); | ||
|
|
||
| border-radius: var(--radius-control-small); | ||
| border: 1px solid var(--color-dividers); | ||
| background-color: var(--color-background); | ||
| padding: 6px 8px; | ||
| overflow-wrap: break-word; | ||
|
|
||
| transition: opacity 300ms; | ||
| `; |
There was a problem hiding this comment.
Moved from HoverTooltip.tsx
ShrimpCryptid
requested review from
toloudis and
rugeli
and removed request for
a team
rugeli
approved these changes
Dec 11, 2024
toloudis
approved these changes
Dec 16, 2024
Comment on lines
+203
to
+204
| const [lastValidHoveredId, setLastValidHoveredId] = useState<number>(-1); | ||
| const [showObjectHoverInfo, setShowObjectHoverInfo] = useState(false); |
There was a problem hiding this comment.
since you called this out, it's definitely odd to call it a "valid" hovered id when -1 is allowed!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Refactors the rendering logic for hover tooltips into a separate component. As part of this change, I also changed some variable names for clarity and moved component styling.
This will eventually let me add a tag tooltip that follows the mouse as part of #484!
Estimated size: small, 10-20 minutes (faster if you compare deleted changes!!!)
Solution
Viewer.tsxand into a new component,CanvasHoverTooltip.tsx.HoverTooltip.tsxand intoCanvasHoverTooltip.tsx.Viewer.tsxfor clarity.Steps to Verify: