Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Snap scatterplot hover to currently selected track #494

Merged
merged 7 commits into from
Jan 9, 2025

Conversation

ShrimpCryptid
Copy link
Contributor

@ShrimpCryptid ShrimpCryptid commented Dec 7, 2024

Problem

Closes #493, "difficult to hover + click points in a track in the scatterplot"! You can now hover on the currently selected track, and click off of it to deselect it.

New changes have been shown to and approved by scientists (Chantelle).

Estimated review size: small, 10 minutes

Solution

  • Hover tooltips are now disabled for all points except the track when a track is selected.
  • Clicking off of the track in an empty area of the canvas deselects the track.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Steps to Verify:

  1. Open the preview link: https://allen-cell-animated.github.io/timelapse-colorizer/pr-preview/pr-494/
  2. Switch to the scatter plot and click on a point.
  3. Try clicking any points along the track.
  4. Deselect the track by clicking off of it.
    (Compare with the public build at https://timelapse.allencell.org)

Screenshots (optional):

image

@ShrimpCryptid ShrimpCryptid added the new feature New feature or request label Dec 7, 2024
@ShrimpCryptid ShrimpCryptid self-assigned this Dec 7, 2024
Copy link

github-actions bot commented Dec 7, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2025-01-09 17:55 UTC

Copy link

github-actions bot commented Dec 7, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 75.08% 5260 / 7005
🔵 Statements 75.08% 5260 / 7005
🔵 Functions 57.62% 136 / 236
🔵 Branches 80.81% 438 / 542
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/components/Tabs/scatter_plot_data_utils.ts 58.49% 100% 27.27% 58.49% 64-72, 106-107, 113-122, 126-133, 137-144, 151-156, 160-179, 188-212
Generated in workflow #1272

@ShrimpCryptid ShrimpCryptid marked this pull request as ready for review December 9, 2024 17:08
@ShrimpCryptid ShrimpCryptid requested a review from a team as a code owner December 9, 2024 17:08
@ShrimpCryptid ShrimpCryptid requested review from meganrm and ascibisz and removed request for a team December 9, 2024 17:08
@ShrimpCryptid ShrimpCryptid marked this pull request as draft December 9, 2024 17:12
@ShrimpCryptid ShrimpCryptid marked this pull request as ready for review December 10, 2024 18:03
Copy link

@ascibisz ascibisz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even as a novice user, this is a much better user experience! Seems like an adventure fighting working with plotly to get this ready 😆, I appreciate all the comments. LGTM!

@ShrimpCryptid ShrimpCryptid merged commit 13cc9d2 into main Jan 9, 2025
3 checks passed
@ShrimpCryptid ShrimpCryptid deleted the feature/restrict-scatter-hover branch January 9, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Difficult to hover + click current track in scatter plot
3 participants