refactor: Moved tab rendering logic (annotations pt. 2) #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ShrimpCryptid
requested review from
rugeli and
ascibisz
and removed request for
a team
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
rugeli
approved these changes
Dec 19, 2024
Comment on lines
+880
to
+898
| <ScatterPlotTab | ||
| dataset={dataset} | ||
| currentFrame={currentFrame} | ||
| selectedTrack={selectedTrack} | ||
| findTrack={findTrack} | ||
| setFrame={setFrameAndRender} | ||
| isVisible={config.openTab === TabType.SCATTER_PLOT} | ||
| isPlaying={timeControls.isPlaying() || isRecording} | ||
| selectedFeatureKey={featureKey} | ||
| colorRampMin={colorRampMin} | ||
| colorRampMax={colorRampMax} | ||
| colorRamp={getColorMap(colorRampData, colorRampKey, colorRampReversed)} | ||
| categoricalPalette={categoricalPalette} | ||
| inRangeIds={inRangeLUT} | ||
| viewerConfig={config} | ||
| scatterPlotConfig={scatterPlotConfig} | ||
| updateScatterPlotConfig={updateScatterPlotConfig} | ||
| showAlert={showAlert} | ||
| /> |
There was a problem hiding this comment.
This is already clean and readable, I just have a thought for future maintainability if we anticipate adding more props: would it be less error prone to group related props into a single config object instead of passing them individually?
For instance:
const scatterPlotDisplayConfig = {
dataset,
currentFrame,
...
};
const scatterPlotColorConfig = {
colorRampMin,
colorRampMax,
...
};
<ScatterPlotTab
displayConfig={scatterPlotDisplayConfig}
...
>
There was a problem hiding this comment.
Oooh, yes! We already kind of do this for the scatterPlotConfig and viewerConfig, but you're right that the color ramps etc. could be bundled together into an object as well. I'll open an issue ticket for this and update here. :')
There was a problem hiding this comment.
Opened as #502
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Part 2 of ??? for #484, prototyping annotations.
This change is a simple code move, with a little extra placeholder for the annotation tab thrown in.
Estimated review size: small, <10 minutes
Solution
Type of change
Steps to Verify: