fix: Selected object outline has a consistent width with zoom #505
+10
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage Report
File CoverageNo changed files found. |
ShrimpCryptid
requested review from
interim17 and
frasercl
and removed request for
a team
frasercl
approved these changes
Jan 3, 2025
aswallace
approved these changes
Jan 7, 2025
| @@ -91,11 +93,10 @@ vec4 getColorRamp(float val) { | |||
|
|
|||
| bool isEdge(vec2 uv, ivec2 frameDims) { | |||
There was a problem hiding this comment.
Good catch, it can be removed!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Closes #187, "Outlines are inconsistently thin on high-resolution frames."
We had an issue where the outlines were always 2 pixels wide in the dimensions of the original data. For very high-resolution images, this resulted in very thin outlines that were hard to see.
Outlines are now 2 pixels wide regardless of zoom level or image dimensions!
Estimated review size: tiny, <5 minutes
Solution
Type of change
Steps to Verify:
Screenshots (optional):