fix: Fixes bug where clicking on the canvas did not remove focus from other elements #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage Report
File CoverageNo changed files found. |
ShrimpCryptid
force-pushed
the
fix/blur-inputs-on-viewport-click
branch
from
69d6087 to
5c590dd
Compare
ShrimpCryptid
commented
Feb 4, 2025
| // Prevent the default behavior for mouse clicks that would cause text | ||
| // selection, but keep the behavior where focus is removed from other | ||
| // elements. | ||
| event.preventDefault(); |
There was a problem hiding this comment.
This was what was causing the bug, but event.preventDefault is still mostly desired behavior. Simulate the focus behavior by blurring the active element in the document.
ShrimpCryptid
requested review from
toloudis and
ascibisz
and removed request for
a team
Base automatically changed from
feature/annotation-select-whole-tracks
to
main
February 4, 2025 17:45
ascibisz
approved these changes
Feb 5, 2025
toloudis
reviewed
Feb 11, 2025
| // elements. | ||
| event.preventDefault(); | ||
| if (document.activeElement instanceof HTMLElement) { | ||
| document.activeElement.blur(); |
There was a problem hiding this comment.
Ooh, good question. I don't think blurring itself would do anything because it's not an element that has focus behavior or styling, but I'll add a check in and skip blurring if it's the same element. Thank you!
toloudis
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Closes #535, "clicking on viewport should remove focus from other elements."
Estimated review size: tiny, <5 minutes
Solution
Type of change