You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes#514, "Annotation - select range of track with shortcut keys." (Also closes#531, "optimize track building in Dataset".)
When Shift is held, the time annotation mode can change a range of annotations within the same track. Click a track, go to a different timepoint, and click again with Shift held down to label (or unlabel) all of the objects in between.
Estimated review size: medium, 15-20 minutes
Solution
Moved annotation click handling behavior out of Viewer.tsx and into a new callback, handleAnnotationClick.
Added a new React hook, useShortcutKey, which tracks whether a given key is pressed down.
Added a new behavior to the time selection mode where, when annotation editing is enabled, clicking one an object in a track and then holding Shift while clicking another object will annotate the segments of the track in between those two points.
Shift clicking again on the same object will toggle the range.
Added a tag in the hover tooltip that appears when shift is pressed and a range of cells will be edited.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Closes #514, "Annotation - select range of track with shortcut keys." (Also closes #531, "optimize track building in Dataset".)
When
Shiftis held, the time annotation mode can change a range of annotations within the same track. Click a track, go to a different timepoint, and click again with Shift held down to label (or unlabel) all of the objects in between.Estimated review size: medium, 15-20 minutes
Solution
Viewer.tsxand into a new callback,handleAnnotationClick.useShortcutKey, which tracks whether a given key is pressed down.Misc:
clear()method inAnnotationDatato support future work in Annotations - clear annotations when switching datasets #559Datasetnow caches built tracks for performance, as described in Optimize track building inDataset#531.Type of change
Steps to Verify:
Screenshots (optional):
Show-n-tell images/animations here