refactor: Moved backdropKey, changed store access to use inline selector pattern (state pt. 10)
#588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-state-refactor-10-cleanup
…state-refactor-10-cleanup
|
ShrimpCryptid
commented
Mar 11, 2025
There was a problem hiding this comment.
I decided to move backdropKey into the DatasetSlice because it's highly dependent on the dataset. This let me remove the dependency on BackdropSlice.
ShrimpCryptid
force-pushed
the
zustand-state-refactor-10-cleanup
branch
from
8b43fc2 to
804fadf
Compare
ShrimpCryptid
requested review from
meganrm and
frasercl
and removed request for
a team
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||
ShrimpCryptid
force-pushed
the
zustand-state-refactor-10-cleanup
branch
from
804fadf to
2a23519
Compare
ShrimpCryptid
changed the title
backdropKey, changed store access to use inline selector patternbackdropKey, changed store access to use inline selector pattern (state pt. 10)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Part 10 of (12)??? for #492, "refactor state management."
This change is pretty unexciting. It moves the
backdropKeyinto theDatasetSlicewhich cleans up some dependencies, and also changes our state access to the inline selector pattern which is better for linting & detecting deprecated dependencies.Estimated review size: small, 10 minutes
Solution
useShallow.backdropKeyintoDatasetSlice, allowingDatasetSliceto be agnostic ofBackdropSlice.backdropKeyinBackdropSliceto sync backdrop visibility.Steps to Verify:
(Note: there's a known bug when switching datasets/collections where the frame may be incorrect. I'm going to see if it goes away when I move more Dataset/Collection switching logic into the store.)