Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix info panel accordion collapse on Safari #177

Merged
merged 1 commit into from
Dec 1, 2023
Merged

fix info panel accordion collapse on Safari #177

merged 1 commit into from
Dec 1, 2023

Conversation

toloudis
Copy link
Contributor

Fixing #176

Seems to work to just add display:none to the collapsed css.
Could use help testing/verifying on Chrome/Firefox/Safari

@toloudis toloudis requested a review from a team as a code owner November 30, 2023 22:59
@toloudis toloudis requested review from meganrm, blairlyons, interim17, ShrimpCryptid, frasercl and ascibisz and removed request for a team November 30, 2023 22:59
ShrimpCryptid
ShrimpCryptid approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@ShrimpCryptid ShrimpCryptid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works in my Chrome and Firefox 👍

@toloudis toloudis merged commit 5e92a5e into main Dec 1, 2023
3 checks passed
@toloudis toloudis deleted the fix/safari-collapse-space branch December 1, 2023 19:04
@frasercl frasercl mentioned this pull request Apr 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShrimpCryptid ShrimpCryptid ShrimpCryptid approved these changes

@meganrm meganrm Awaiting requested review from meganrm meganrm is a code owner automatically assigned from allen-cell-animated/core-devs

@blairlyons blairlyons Awaiting requested review from blairlyons blairlyons is a code owner automatically assigned from allen-cell-animated/core-devs

@interim17 interim17 Awaiting requested review from interim17 interim17 is a code owner automatically assigned from allen-cell-animated/core-devs

@frasercl frasercl Awaiting requested review from frasercl frasercl is a code owner automatically assigned from allen-cell-animated/core-devs

@ascibisz ascibisz Awaiting requested review from ascibisz ascibisz is a code owner automatically assigned from allen-cell-animated/core-devs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@toloudis @ShrimpCryptid