synchronize channel loading during playback only #195
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toloudis
requested review from
blairlyons and
interim17
and removed request for
a team
|
LGTM, built and tested locally with dev build of I'll confess I haven't fully understood the related volume viewer code, but I think I get the idea and it's working here, and I can log the toggled |
interim17
approved these changes
Feb 26, 2024
blairlyons
approved these changes
Mar 6, 2024
|
#199 includes this change now |
Merged
|
Closing in favor of #199 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on api changes from allen-cell-animated/vole-core#185
This calls a function to tell the volume loader to wait for all channels to arrive before updating the displayed volume, only during playback modes. Fixes #190 after both pull requests go through.
After the dependent PR is approved, there will be a volume-viewer version bump added to this PR. That will fix the CI breakage.
Estimated time to review: ~5 minutes