Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Updated name from Volume Viewer to Vol-E on landing page #335

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

ShrimpCryptid
Copy link
Contributor

@ShrimpCryptid ShrimpCryptid commented Nov 12, 2024

Problem

Part of #331, renaming. Renames the app to "Vol-E" in the header, HTML documents, landing page content, and README.

Estimated review size: tiny, <5 minutes

Solution

  • Renames "Volume Viewer" to "Vol-E".
  • Adjusts some grammar for consistency (oxford commas, etc.)

Screenshots (optional):

Interactive preview here: https://allen-cell-animated.github.io/website-3d-cell-viewer/pr-preview/pr-335/

image

@ShrimpCryptid ShrimpCryptid added the documentation Improvements or additions to documentation label Nov 12, 2024
@ShrimpCryptid ShrimpCryptid self-assigned this Nov 12, 2024
@ShrimpCryptid ShrimpCryptid marked this pull request as ready for review November 12, 2024 21:19
@ShrimpCryptid ShrimpCryptid requested a review from a team as a code owner November 12, 2024 21:19
@ShrimpCryptid ShrimpCryptid requested review from toloudis and rugeli and removed request for a team November 12, 2024 21:19
Copy link

github-actions bot commented Nov 12, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-11-18 21:22 UTC

Copy link
Contributor

@toloudis toloudis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine although it always makes me nervous when we change copy for no reason. I'm not sure who of non-software engineering should review, maybe UX.

@ShrimpCryptid
Copy link
Contributor Author

Seems fine although it always makes me nervous when we change copy for no reason. I'm not sure who of non-software engineering should review, maybe UX.

Makes sense! I checked and UX had no issues with these changes during office hours today :)

@ShrimpCryptid ShrimpCryptid merged commit efb0729 into main Nov 18, 2024
4 checks passed
@ShrimpCryptid ShrimpCryptid deleted the refactor/rename-website branch November 18, 2024 21:19
@toloudis toloudis mentioned this pull request Dec 11, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants